Conversation
This function observes a livedata until the value of the light is no longer null. When this is true it executes a given action
This is needed because for example livedata can contain null
This works, but it is not perfect, that the reachable state is calculated in the LightDetailViewModel. This means that other ViewModels and other places would need to implement the same thing
# Conflicts: # app/src/main/java/org/d3kad3nt/sunriseClock/ui/light/LightsFragment.java # app/src/main/java/org/d3kad3nt/sunriseClock/ui/light/lightDetail/LightDetailViewModel.java
This was done because it had no additional info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the usage of the app when the app cant reach the endpoint.
It shows the cached Lights in the light List and sets the "isReachable" State of the Lights to false.